Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with hitslop #4

Closed
hirbod opened this issue May 26, 2020 · 8 comments
Closed

Issue with hitslop #4

hirbod opened this issue May 26, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@hirbod
Copy link
Contributor

hirbod commented May 26, 2020

Hello @gorhom . I wanted to thank you again, after a long time of trying I was able to replace Recylerview with your library and achieved a very satisfying performance.

The only problem I could not solve yet is the hitslop of the sticky element. Since the element overlays my thumbs, which are also clickable, I often have two actions (once opening my story and once the action on the button).

How can I optimize this? I would like to be able to define a larger area so that no touch is registered on the thumbnail.

I have made you a video to illustrate this.
https://streamable.com/pmlrit

Unfortunately you can't see my finger on the video, but I always try to open the action of the sticky element only, but I always open the story too. Only if I touch in a very special area I get it right but the UX is not so good at this.

@hirbod hirbod added the bug Something isn't working label May 26, 2020
@gorhom
Copy link
Owner

gorhom commented May 28, 2020

this been fixed with Release v1.2.0

@gorhom gorhom closed this as completed May 28, 2020
@hirbod
Copy link
Contributor Author

hirbod commented May 28, 2020

@gorhom unfortunately its not fixed on android. And android really doesn't care where in that area I tab, it always fires both the item and sticky press. iOS is working perfectly fine

@gorhom
Copy link
Owner

gorhom commented May 28, 2020

ughhh , okay i'll look into later today 👍

@gorhom gorhom reopened this May 28, 2020
@gorhom
Copy link
Owner

gorhom commented May 28, 2020

hi @hirbod could you try install from master, it should solve hitslop and double press event on android 👍

yarn add ssh://git@github.com:gorhom/react-native-sticky-item

@hirbod
Copy link
Contributor Author

hirbod commented May 28, 2020

Well, a big "dank u" @gorhom. Works perfectly! Now iOS and Android have feature parity :)

@gorhom
Copy link
Owner

gorhom commented May 28, 2020

graag gedaan "du bist willkommen", now its release v1.2.1 :)

@gorhom gorhom closed this as completed May 28, 2020
@hirbod
Copy link
Contributor Author

hirbod commented May 28, 2020

PS: your implementation with reanimated is MUCH smoother then facebook's :D (at least on iOS)
Facebook feels sloppy and janky

@gorhom
Copy link
Owner

gorhom commented May 28, 2020

yeah i notice while i was analysing its animation 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants