Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle initial index #6

Merged
merged 2 commits into from
May 28, 2020
Merged

feat: handle initial index #6

merged 2 commits into from
May 28, 2020

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented May 27, 2020

closing #4 , #5

@gorhom
Copy link
Owner Author

gorhom commented May 27, 2020

hi @hirbod , could you test this pr , it should close #4 and #5

yarn add ssh://git@github.com:gorhom/react-native-sticky-item#feature/handle-initial-index

@hirbod
Copy link
Contributor

hirbod commented May 28, 2020

Hi @gorhom,

thanks, I will check that out. I see you have imported TouchableOpacity from RNGH, let me see if this works for me without that (cause I am using TouchableScale).
And I've seen that you implemented getItemLayout (I also did this locally, but even better if the library takes care of that)

I'll report back, gonna test this now

@hirbod
Copy link
Contributor

hirbod commented May 28, 2020

Hi @gorhom, I tried your fixes and they work indeed, but as I thought, only when I import TouchableOpacity from RNGH. Not exactly what I would love to use, since I am using https://github.com/kohver/react-native-touchable-scale, but its ok for me. Using TouchableOpacity on my Item with your fixes works great on that Hitslop.

@gorhom
Copy link
Owner Author

gorhom commented May 28, 2020

glad to hear that, and indeed TouchableOpacity from RNGH will always be better suitable with gesture handler interactions.

Thanks for reporting/testing it :)

@gorhom gorhom merged commit 269f84c into master May 28, 2020
@hirbod
Copy link
Contributor

hirbod commented May 28, 2020

You're welcome, thanks for your work. I will fork touchable-scale and rework it to use RNGH, it should work afterwards like I need it.

@gorhom gorhom deleted the feature/handle-initial-index branch June 1, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants