Storybook deploy #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illustrova
commented
May 25, 2021
| @@ -62,3 +64,20 @@ jobs: | |||
| with: | |||
| folder: ./product/build | |||
| branch: gh-pages | |||
|
|
|||
| ## The following steps are for storybook deployment. Since we host product in the root, storybook will be overwritten every time we deploy a product. With these steps we restore it back | |||
| - name: Build design tokens | |||
There was a problem hiding this comment.
Copy-pasted code
Illustrova
commented
May 25, 2021
| @@ -7,7 +7,7 @@ | |||
| "@testing-library/jest-dom": "^5.11.4", | |||
| "@testing-library/react": "^11.1.0", | |||
| "@testing-library/user-event": "^12.1.10", | |||
| "design-system": "0.1.0", | |||
| "design-system": "*", | |||
There was a problem hiding this comment.
design-system version set to any
varya
approved these changes
May 25, 2021
|
After only 70+ tests it's (hopefully) working as it should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here comes new deployment system - we deploy product in the root, see example at
https://illustrova.github.io/ws-workflow-test/, and storybook under the subpath:https://illustrova.github.io/ws-workflow-test/storybook.This setup has few drawbacks (?) though.
I remember you didn't want this, but the thing is that the workflow fill fail every time the version doesn't match. Even if you are not working on product yet, and only want to deploy storybook, immediately after the design-system version is bumped, it has to match in product workspace. Seems yarn cannot install dependencies for selected workspace only. So either this, or to instruct participants to change it every time.