[docs] Note StrictSlash re-direct behaviour #308 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* StrictSlash enabled routes return a 301 to the client * As per the HTTP standards, non-idempotent methods, such as POST or PUT, will be followed with a GET by the client * Users should use middleware if they wish to change this behaviour to return a HTTP 308.
elithrar
commented
Dec 2, 2017
mux.go
Outdated
| @@ -164,13 +164,18 @@ func (r *Router) GetRoute(name string) *Route { | |||
| // StrictSlash defines the trailing slash behavior for new routes. The initial | |||
| // value is false. | |||
| // | |||
| // When true, if the route path is "/path/", accessing "/path" will redirect | |||
| // When true, if the route path is "/path/", accessing "/path" will perform a redirect | |||
There was a problem hiding this comment.
Need to fix. Can't do that in GitHub.
There was a problem hiding this comment.
Introduced a space and can’t edit my branch via the web UI (not at my laptop) 😉
Interesting numerical coincidence :) |
|
🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #308