Skip to content

Commit

Permalink
Add go.mod file for vgo dependency management. (#145)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kisielk
kisielk authored Feb 20, 2018
1 parent 6ba88b7 commit 7087b4d
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions go.mod
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module "github.com/gorilla/sessions"

require (
"github.com/gorilla/context" v1.1
"github.com/gorilla/securecookie" v1.1
)

4 comments on commit 7087b4d

@rsc
Copy link

@rsc rsc commented on 7087b4d Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for adding this. Have you run vgo with this? I would have expected it to replace v1.1 with v1.1.0 during reformatting. If not, that's a bug in vgo. Semver must be three numbers. (And you also need tags with exactly three numbers; if the GitHub tag is v1.1 it will be ignored.)

@kisielk
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsc yes, I generated this with vgo build ... using b6ca6ae975e2b066c002388a896833851a9e54a9 of vgo

@rsc
Copy link

@rsc rsc commented on 7087b4d Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks. Not sure, but perhaps a bug.

@cryptix
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into a problem with this .0 missing from the tag. Also with tags vX.Y (no .Z) being selected from other packages with only tags and no go.mod file.

I also couldn't overwrite them from my projects go.mod file and so had to make a local fork and publish a tag on it to get my program to resolve its dependencies with vgo. here is my go.mod file.

Please sign in to comment.