Handle errcheck warnings #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
jaitaiwan
requested changes
Jun 19, 2024
jaitaiwan
previously approved these changes
Jul 1, 2024
|
@canelohill I had to manually resolve a conflict. Can you check and make sure that fits what you think should happen? |
jaitaiwan
approved these changes
Jul 2, 2024
jaitaiwan
approved these changes
Jul 2, 2024
|
The PR looks good after merges. |
|
@canelohill can’t seem to merge it says there’s conflicts |
The package ignored errors from net.Conn Set*Deadline in a few places. Update the package to return these errors to the caller. Ignore all other errors reported by errcheck. These errors are safe to ignore because - The function is making a best effort to cleanup while handling another error. - The function call is guaranteed to succeed. - The error is ignored in a test.
|
The PR should merge clean now. |
|
Cheers thanks for that. I was surprised cause usually I get the opportunity to resolve conflicts manually but this time there was no option. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The package ignored errors from net.Conn Set*Deadline in a few places. Update the package to return these errors to the caller.
Ignore all other errors reported by errcheck. These errors are safe to ignore because
Related Tickets & Documents
Added/updated tests?
Run verifications and test
make verifyis passingmake testis passing