Support TLS connection to HTTP Proxy

[134130]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Go Version Update
• Dependency Update

Description

• Support TLS Connection between websocket client and http proxy.

cc. @adrianosela

Related Tickets & Documents

• Closes [feature] Support for proxying websocket through https proxy #739
• Closes Is https not supported?  #794

Added/updated tests?

• Yes
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

Run verifications and test

• make verify is passing
• make test is passing

[134130]

Also need to set a deadline for the dialing to proxy, so moved the line up.

[134130]

Previously, only had a temporary proxy implementation, and couldn't test the TLS proxy, so implemented it.

[adrianosela]

Suggestion: I think you probably want to exit as soon as one io.Copy hits EOF...

Here's two ways I think you can achieve this:

	var wg sync.WaitGroup
	defer wg.Wait()

	wg.Add(1)
	go func() {
		defer wg.Done()

		// abort blocked reads from upstream when done reading from conn
		defer upstream.SetDeadline(time.Now().Add(-1 * time.Hour))

		_, _ = io.Copy(upstream, conn)
	}()

	wg.Add(1)
	go func() {
		defer wg.Done()

		// abort blocked reads from conn when done reading from upstream
		defer conn.SetDeadline(time.Now().Add(-1 * time.Hour))

		_, _ = io.Copy(conn, upstream)
	}()

OR more simple - block on an unbuffered channel:

        done := make(chan struct{})

	go func() {
		_, _ = io.Copy(upstream, conn)
                done <- struct{}{}
	}()

	go func() {
		_, _ = io.Copy(conn, upstream)
               done <- struct{}{}
	}()

        <- done

[134130]

Yes, I prefer the below. I used wg because It's just a test helper function.

I'll change to the below one.

[adrianosela]

Looks great :D

Thanks so much for hopping on this so quickly. Im wondering what kind of testing was done (aside from unit tests).

[134130]

@adrianosela
Actually, I failed to found well-known proxies which supports TLS Listening.

I'm making HTTPS Proxy in my work, in golang, and I tested with this.