Index spi #4
Draft
Index spi #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate getIndexName and getId in IndexType
5 tasks
gortiz
changed the base branch from
index-spi-remove-columnindextype
to
master
gortiz
changed the base branch from
master
to
index-spi-remove-columnindextype
…en when user explicitly ask for raw encoding
…dIndexAndDictionaryBasedForwardIndexCreator
…uded in SegmentV1V2ToV3FormatConverter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial draft PR related to apache#10183. The whole PR is in apache#10184. It isn't intended to be merged as it is and it doesn't require to compile or pass the checks. It has been created in order to make it easier to understand the PR with all the changes.
This is the partial PR with changes since #3. To read the PR with all changes on master see apache#10184.
This PR shows most of the semantic changes together, where different
IndexTypes have the responsibility of the creation ofIndexCreators,IndexReaders andIndexHandlers. In a future version they should also createMutableIndexes.