Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code panics for Unicode U+10000 #53

Closed
tja opened this issue Mar 10, 2021 · 3 comments · Fixed by #56
Closed

Code panics for Unicode U+10000 #53

tja opened this issue Mar 10, 2021 · 3 comments · Fixed by #56

Comments

@tja
Copy link

tja commented Mar 10, 2021

This code panics:

slug.Make("𐀀")

This is due to the internal use of rainycape/unidecode, which can not handle Unicode character U+10000, see rainycape/unidecode#8.

Given the inactivity of the upstream package, it might be worth filtering out the character in question before passing it to unidecode.

matrixik added a commit to gosimple/unidecode that referenced this issue Jul 23, 2021
matrixik added a commit to gosimple/unidecode that referenced this issue Jul 23, 2021
matrixik added a commit that referenced this issue Jul 26, 2021
matrixik added a commit that referenced this issue Jul 26, 2021
@matrixik
Copy link
Member

Thank you for this report and sorry it took so long, burnout is not nice...

I forked https://github.com/rainycape/unidecode to https://github.com/gosimple/unidecode and fixed this issue.

@tja
Copy link
Author

tja commented Jul 26, 2021

Thanks a bunch for the fix.. I really appreciate it.

Sorry to hear about your burnout — I hope you're doing better now!

@matrixik
Copy link
Member

I'm definitely better now, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants