Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): update build #977
chore(core): update build #977
Changes from all commits
dd65e2f
26ef52f
e8b9a8f
857889a
fbc4b01
923ba98
dc9fbe3
f327ae5
2a14b63
289aff2
8621b94
77d7753
8ec6610
1f6de35
5586b72
ed8caa7
394de59
2f0334c
a877e67
1a926ee
c79ebbe
e981887
4cb8c7b
8223c30
415d8ab
6997405
17fd4dc
ca8eea2
2894aa2
1e4a694
f1046ac
fbac45e
b88c3ef
ed1e6b7
c862ce0
562e46d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"main" applies to both ES module and CJS module entry points. There is no
dist/gosling.js
created anymore so we point this togosling.es.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding of this is that with the exception of some configs, we want all files to be treated as ESM so we use this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! Making things work nice (like Vite) might require upgrading those deps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense! I did try upgrading Vite before, but it we're using a plugin (@vitejs/plugin-react-refresh) which requires this version of vite. However, I didn't realize until now that the package is now deprecated in favor of @vitejs/plugin-react.
I'll switch to @vitejs/plugin-react and upgrade vite if that sounds good!
This file was deleted.