-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian Bookworm to integration-tests #902
base: master
Are you sure you want to change the base?
Conversation
A few results for the ticket. The new container image runs in podman without any problems. In docker the container terminates immediately. The old cent os image does not run on my local machine as well. It behaves in the same way as in the github pipeline (my tests). The container freezes without starting the services it contains (webserver/proxy). The images all contain more or less systemd/init. This is not really an architecture or a use case for containers. Starting multiple processes could also be done with the help of e.g. supervisord. The real reason why init/systemd is included is probably to check services via goss. This would certainly not be possible in standard containers. |
Ok, so I think we need to be careful with upgrading different Linux versions. The purpose of the integration tests is to test against real world examples of services/package managers that goss supports. Lines 162 to 179 in aed5633
So if upgrading a distro will move it from say sysV init to systemd then the integration tests now have a gap in coverage. Also, it probably means they are potentially redundant (e.g. Debian may no longer be providing any value over ubuntu tests). |
I understand the arguments. And that is also correct. On the other hand "test against real world examples" is not possible with the current versions that are EOL.
|
sure, I wonder if that part of the codebase should be deprecated or if I need to see if any non-EOL linux distributions still use sysV init. |
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change
The current used images / Dockerfiles are EoL. Starting add a supported Debian Bookworm image.
I did a few tests. Since Debian Jessy the check for run level does not work anymore.