Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #974

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Update dependencies #974

merged 1 commit into from
Sep 14, 2024

Conversation

ripienaar
Copy link
Collaborator

@ripienaar ripienaar commented Sep 11, 2024

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Dependency updates - mainly to get the new sprig release which in turns resolves a long standing issue after mergo renamed itself.

Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar
Copy link
Collaborator Author

I dont think these failures have anything to do with me change

@aelsabbahy
Copy link
Member

Probably not, CI is like 95% transitioned to GHA. Going to merge this, looks great!

Can you add a link to the mergo sprig issue.. curious to learn more about it.

@aelsabbahy aelsabbahy merged commit 60fb9bd into goss-org:master Sep 14, 2024
6 of 7 checks passed
@ripienaar
Copy link
Collaborator Author

Mergo renamed itself. Many projects adopted the new name but sprig had no releases for ages. This caused go mode to fail badly

fir me sprig and goss were the last dependencies that didn’t move yet so now things should be better

https://github.com/darccio/mergo/releases/tag/v1.0.0

@aelsabbahy
Copy link
Member

Cool, thanks for the link. I haven't run into too many go dependency quirks.. but perhaps I've just gotten lucky so far. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants