Merge pull request #4 from gostaticanalysis/fix-panic-for-funclit

Fix panic for func lit
gostaticanalysis · Aug 12, 2021 · 6bc5e75 · 6bc5e75
2 parents b11e963 + 2dd381a
commit 6bc5e75
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/passes/fieldtype/fieldtype.go b/passes/fieldtype/fieldtype.go
@@ -107,8 +107,15 @@ func fieldkey(pass *analysis.Pass, fs map[string]*types.Func, call *ast.CallExpr
 		id = fun
 	case *ast.SelectorExpr:
 		id = fun.Sel
+	default:
+		return "", ""
 	}
+
 	obj := pass.TypesInfo.ObjectOf(id)
+	if obj == nil {
+		return "", ""
+	}
+
 	f := fs[obj.Name()]
 	if f == nil || f != obj {
 		return "", ""

diff --git a/passes/fieldtype/testdata/src/a/a.go b/passes/fieldtype/testdata/src/a/a.go
@@ -8,4 +8,5 @@ func f() {
 	zap.Any("id", "100")     // OK - ignore
 	zap.Reflect("id", "100") // OK - ignore
 	zap.String("xxx", "100") // OK
+	func() {}()              // OK
 }