begin event loop and EngineInstance
#733
Conversation
Sharktheone
added
useragent
| use tokio::task::{spawn_blocking, LocalSet}; | ||
| use url::Url; | ||
|
|
||
| pub struct EngineInstance<C: ModuleConfiguration> { |
There was a problem hiding this comment.
I don't know exactly what an engine instance is... but from context I don't understand why it needs a title or url?
There was a problem hiding this comment.
It is basically a tab. It will manage the event loop, the web event loop and everything else.
It needs the title and url, so JS can ask for it
| use crate::chrome::ChromeHandle; | ||
| use crate::config::HasRenderBackend; | ||
|
|
||
| pub trait HasChrome: HasRenderBackend + Sized { |
There was a problem hiding this comment.
Please describe what chrome is and what it does...
There was a problem hiding this comment.
Yeah, I still need many comments. I am also not completely happy about the HasChrome thingy.
There was a problem hiding this comment.
Me neither, but more about the connotation with the chrome browser. I'm not 100% sure what it is for, but we could see if we can find a better naming for it.. for now, don't worry about it too much,.. we can always rename things when we find better names or ways... (like gosub_interface)
Sharktheone
force-pushed
the
event-loop/initial
branch
2 times, most recently
from
a5c91b3 to
ddfcd8c
Compare
Sharktheone
force-pushed
the
event-loop/initial
branch
from
ddfcd8c to
85528d8
Compare
Sharktheone
force-pushed
the
event-loop/initial
branch
from
85528d8 to
88ee8fc
Compare
No description provided.