Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telegram): updateShortMessage fix 'FromID' field #289

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

shadowspore
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #289 (7aba8ba) into main (cd609a3) will decrease coverage by 0.11%.
The diff coverage is 37.50%.

❗ Current head 7aba8ba differs from pull request most recent head 2864b07. Consider uploading reports for the commit 2864b07 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   70.33%   70.22%   -0.12%     
==========================================
  Files         283      283              
  Lines        8759     8773      +14     
==========================================
  Hits         6161     6161              
- Misses       2008     2016       +8     
- Partials      590      596       +6     
Impacted Files Coverage Δ
telegram/client.go 73.20% <ø> (ø)
telegram/self.go 46.66% <25.00%> (-24.77%) ⬇️
telegram/handle_updates.go 79.80% <50.00%> (-2.85%) ⬇️
internal/mtproto/rpc.go 40.54% <0.00%> (-24.33%) ⬇️
internal/rpc/options.go 90.00% <0.00%> (-10.00%) ⬇️
transport/server.go 68.08% <0.00%> (-4.26%) ⬇️
internal/rpc/engine.go 71.31% <0.00%> (-4.10%) ⬇️
internal/mtproto/read.go 48.38% <0.00%> (-2.16%) ⬇️
telegram/internal/manager/conn.go 86.48% <0.00%> (+2.70%) ⬆️
internal/pool/pool.go 68.61% <0.00%> (+9.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd609a3...2864b07. Read the comment docs.

@shadowspore shadowspore requested a review from ernado April 10, 2021 06:38
Copy link
Contributor

@tie tie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think that would work since getSelfID doesn’t invalidate cached ID on re-login as different user. Perhaps we can leave FromID optional in case of Out message and handle that somewhere at a higher level?

@shadowspore shadowspore force-pushed the fix/updateShortMessage-selfID branch from 7aba8ba to 2864b07 Compare April 10, 2021 08:49
@shadowspore
Copy link
Member Author

I don’t think that would work since getSelfID doesn’t invalidate cached ID on re-login as different user. Perhaps we can leave FromID optional in case of Out message and handle that somewhere at a higher level?

Agreed

@shadowspore shadowspore changed the title fix(telegram): updateShortMessage incorrect selfID fix(telegram): updateShortMessage fix 'FromID' field Apr 10, 2021
@ernado ernado merged commit b8e5dda into gotd:main Apr 11, 2021
@shadowspore shadowspore deleted the fix/updateShortMessage-selfID branch June 9, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants