-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop go1.16 from test-matrix, replace deprecated io/ioutil, and update golangci-lint to v1.49.0 #245
Conversation
Both go1.16 and go1.17 reached EOL; keeping go1.17 for now, as there may still be projects that are slightly behind. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also replacing some of them, as there's more linters that check for this now (revive being one of them), so "fixing" them prevents having to add more linters to the list. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1011a81
to
d7bf7af
Compare
internal/maint/maint.go:1:1: package-comments: should have a package comment (revive) package maint // import "gotest.tools/v3/internal/maint" internal/format/diff.go:1:1: package-comments: should have a package comment (revive) package format icmd/internal/stub/main.go:1:1: package-comments: should have a package comment (revive) package main internal/source/defers.go:1:1: package-comments: should have a package comment (revive) package source internal/assert/assert.go:1:1: package-comments: should have a package comment (revive) package assert Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also replaced deprecated linters: WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive. WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
d7bf7af
to
5b51cec
Compare
@@ -1,3 +1,4 @@ | |||
// Package main produces a test-binary used in tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I was a bit on the fence wether to disable this specific check in the linter or to add the (quite "boiler-plate-y" comments), but most packages already had a Package description, so I thought it'd be useful to be a bit more "strict", and run the linter.
@dnephin @vdemeester 👋 PTAL 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
YW! Hope you're doing well! |
See individual commits for details