Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop go1.16 from test-matrix, replace deprecated io/ioutil, and update golangci-lint to v1.49.0 #245

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

thaJeztah
Copy link
Contributor

See individual commits for details

Both go1.16 and go1.17 reached EOL; keeping go1.17 for now, as there may
still be projects that are slightly behind.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also replacing some of them, as there's more linters that check for this
now (revive being one of them), so "fixing" them prevents having to add
more linters to the list.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the replace_ioutil branch 2 times, most recently from 1011a81 to d7bf7af Compare October 4, 2022 11:26
    internal/maint/maint.go:1:1: package-comments: should have a package comment (revive)
    package maint // import "gotest.tools/v3/internal/maint"
    internal/format/diff.go:1:1: package-comments: should have a package comment (revive)
    package format
    icmd/internal/stub/main.go:1:1: package-comments: should have a package comment (revive)
    package main
    internal/source/defers.go:1:1: package-comments: should have a package comment (revive)
    package source
    internal/assert/assert.go:1:1: package-comments: should have a package comment (revive)
    package assert

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also replaced deprecated linters:

    WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
    WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
    WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.
    WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner.
    WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@@ -1,3 +1,4 @@
// Package main produces a test-binary used in tests.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I was a bit on the fence wether to disable this specific check in the linter or to add the (quite "boiler-plate-y" comments), but most packages already had a Package description, so I thought it'd be useful to be a bit more "strict", and run the linter.

@thaJeztah
Copy link
Contributor Author

@dnephin @vdemeester 👋 PTAL 🤗

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dnephin dnephin merged commit f086d27 into gotestyourself:main Oct 6, 2022
@thaJeztah thaJeztah deleted the replace_ioutil branch October 6, 2022 01:25
@thaJeztah
Copy link
Contributor Author

YW! Hope you're doing well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants