Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gotestsum on illumos/amd64 #373

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Add support for gotestsum on illumos/amd64 #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .project/goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ builds:
- freebsd
- windows
- linux
- illumos
goarch:
- amd64
- arm64
Expand All @@ -36,6 +37,14 @@ builds:
goarch: s390x
- goos: windows
goarch: ppc64le
- goos: illumos
goarch: arm
- goos: illumos
goarch: arm64
- goos: illumos
goarch: s390x
- goos: illumos
goarch: ppc64le
dnephin marked this conversation as resolved.
Show resolved Hide resolved

checksum:
name_template: '{{ .ProjectName }}-{{ .Version }}-checksums.txt'
4 changes: 4 additions & 0 deletions internal/filewatcher/term_illumos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package filewatcher

const tcGet = 0x540d
const tcSet = 0x540e
Comment on lines +3 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are almost certainly right that these constants likely won't change ever, but I wonder if you can't use unix.TCGETS and unix.TCSETS, respectively? If nothing else, having a name makes it a bit less mysterious from where these values originate.

These constants do seem to be present in golang.org/x/sys/unix when GOOS=illumos, at least with recent versions.

$ GOOS=illumos go doc golang.org/x/sys/unix.TCGETS
...
	TCGETS                        = 0x540d
...