Use clippy 1.72 in CI and fix lints (#624)

.github/workflows/rust.yml

@@ -77,7 +77,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@master
         id: rust-toolchain
         with:
-          toolchain: "1.69"
+          toolchain: "1.72"
           components: clippy
 
       - uses: actions/cache@v3

examples/path/globs/src/main.rs

@@ -91,7 +91,7 @@ fn multi_parts_handler(state: State) -> (State, String) {
             bottom.push_str(part);
         }
 
-        vec![top, bottom].join("\n\n")
+        [top, bottom].join("\n\n")
     };
 
     (state, res)

gotham/src/middleware/session/rng.rs

@@ -11,7 +11,7 @@ use rand_chacha::ChaChaCore;
 pub(super) type SessionIdentifierRng = ReseedingRng<ChaChaCore, OsRng>;
 
 pub(super) fn session_identifier_rng() -> SessionIdentifierRng {
-    let os_rng = OsRng::default();
+    let os_rng = OsRng;
     let rng = ChaChaCore::from_entropy();
 
     // Reseed every 32KiB.

gotham/src/router/non_match.rs

@@ -284,7 +284,7 @@ impl From<MethodSet> for Vec<Method> {
         let mut result = methods_with_flags
             .iter()
             .filter_map(|&(ref method, flag)| if flag { Some(method.clone()) } else { None })
-            .chain(method_set.other.into_iter())
+            .chain(method_set.other)
             .collect::<Vec<Method>>();
 
         result.sort_unstable_by(|a, b| a.as_ref().cmp(b.as_ref()));

gotham/src/service/trap.rs

@@ -141,6 +141,7 @@ mod tests {
 
     #[test]
     fn panic() {
+        #[allow(clippy::unnecessary_literal_unwrap)] // false positive? or bad description?
         let new_handler = || {
             Ok(|_| {
                 let val: Option<Pin<Box<HandlerFuture>>> = None;

misc/borrow_bag/src/handle.rs

@@ -24,7 +24,7 @@ pub(crate) fn new_handle<T, N>() -> Handle<T, N> {
 
 impl<T, N> Clone for Handle<T, N> {
     fn clone(&self) -> Handle<T, N> {
-        new_handle()
+        *self
     }
 }