Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masonite #304

Closed
vaibhavmule opened this issue Dec 4, 2018 · 9 comments · Fixed by #379
Closed

Masonite #304

vaibhavmule opened this issue Dec 4, 2018 · 9 comments · Fixed by #379
Labels

Comments

@vaibhavmule
Copy link
Contributor

vaibhavmule commented Dec 4, 2018

Hey,

I will be implementing the backend with Masonite. Masonite is the Modern And Developer Centric Python Web Framework.

Repo: https://github.com/vaibhavmule/masonite-realworld-example-app

@vaibhavmule
Copy link
Contributor Author

@Cameron-C-Chapman just want to clarify for labels that it will be backend implementation not frontend.

@Cameron-C-Chapman
Copy link
Member

@vaibhavmule I fixed that. Thanks!

@vaibhavmule
Copy link
Contributor Author

@Cameron-C-Chapman I have worked on repo and ready and passed all the tests.

@vaibhavmule vaibhavmule changed the title Masonite Framework Masonite Jun 24, 2019
@anishkny
Copy link
Member

@vaibhavmule could you add CI (Travis/Circle/Azure)?

@vaibhavmule
Copy link
Contributor Author

vaibhavmule commented Jun 25, 2019

@anishkny Yes just updated the travis.yml.

@vaibhavmule
Copy link
Contributor Author

@anishkny @Cameron-C-Chapman Just wanted to know, what can be done approved?

@anishkny
Copy link
Member

@vaibhavmule this looks great! Could you run API tests against your backend to ensure it is compliant? preferably in Travis CI

https://github.com/gothinkster/realworld/tree/master/api

@vaibhavmule
Copy link
Contributor Author

vaibhavmule commented Jul 28, 2019

@anishkny
Yeah, I could do that. Is there any example repo as I can have look. Thanks.

@anishkny
Copy link
Member

anishkny commented Aug 2, 2019

Basically you would need to spin up your backend, and then execute:

APIURL=http://localhost:8000/ run-api-tests.sh

(assuming port 8000)

See: https://github.com/gothinkster/realworld/blob/master/api/run-api-tests.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants