Skip to content

chore: update changelog #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore: update changelog #41

merged 1 commit into from
Nov 29, 2023

Conversation

TobTheRock
Copy link
Contributor

breaking change comments where missing

breaking change comments where missing
@TobTheRock TobTheRock requested a review from hoodie November 27, 2023 14:25
@hoodie
Copy link
Contributor

hoodie commented Nov 27, 2023

can you just write into the changelog like that? I think it's generated from the commit history. These changes might just be overwritten. I think you can do this as an empty commit (--allow-empty) and then put the markdown into the commit message.

@TobTheRock
Copy link
Contributor Author

I did not write this manually but I regenerated the changelog with git-cliff using our config. This is what release-plz also uses internally. However it does not regenerate the whole changelog, but just adds a section for the new version. Thus the changes I made here should not be overwritten.

@TobTheRock TobTheRock merged commit 5f77261 into main Nov 29, 2023
@TobTheRock TobTheRock deleted the feature/update-changelog branch November 29, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants