Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for expression in request body when fetching metada… #170

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

anjali9791
Copy link

@anjali9791 anjali9791 commented Aug 12, 2024

…ta sources for appeal

@anjali9791 anjali9791 force-pushed the add_support_for_expression branch 3 times, most recently from 5fb0ccb to 6a13658 Compare August 13, 2024 12:20
@anjali9791 anjali9791 changed the title feat: add support for expression in request body when fetching meatda… feat: add support for expression in request body when fetching metada… Aug 13, 2024
@anjali9791 anjali9791 force-pushed the add_support_for_expression branch from 6a13658 to e1229da Compare August 13, 2024 12:26
@anjali9791 anjali9791 force-pushed the add_support_for_expression branch from e1229da to 727b891 Compare August 13, 2024 12:40
Copy link
Collaborator

@Gadigeppa-J Gadigeppa-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gadigeppa-J Gadigeppa-J merged commit 521ab2d into main Aug 13, 2024
6 checks passed
harishkswami pushed a commit to harishkswami/guardian that referenced this pull request Aug 23, 2024
goto#170)

* feat: add support for expression in request body when fetching metadata sources for appeal

* add a condition in http mock call

---------

Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>
rahmatrhd added a commit that referenced this pull request Aug 27, 2024
* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* lark support

* fix: fix typo in mapstructure annotation

* fix: map old notifier config to new multiple notifiers format

* fix: fix slack client initialization with multiple workspaces

* fix: fix lint errors

* add json config for notifiers

* add json config for notifiers

* add json config for notifiers

* add json config for notifiers

* add json config for notifiers

* add json config for notifiers

* fix review commits

* fix review commits

* feat(email): handling email case sensitive (#165)

* feat(email): handling email case sensitive

* chore: handling list page

* chore: handle case on filter

---------

Co-authored-by: Muhammad Idil Haq Amir <idil.amir@tokopedia.com>

* feat(gate): introduce gate provider (#164)

* feat(gate): introduce gate provider

* fix: send gate api key in query param

* fix: handle non-success http codes

* feat(notifier): expose variables in notifier criteria (#166)

* feat: add support for google_oauth2 token. Related to issue: https://… (#169)

* feat: add support for google_oauth2 token. Related to issue: #168

* add test cases

* add test cases

* add error formatting changes

---------

Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>

* feat: add support for expression in request body when fetching metada… (#170)

* feat: add support for expression in request body when fetching metadata sources for appeal

* add a condition in http mock call

---------

Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>

* ci: lock golangci-lint to v1.59 (#172)

* ci: lock golangci-lint to v1.59

* ci: fix golangci-lint warnings

* chore: fetch creator details before fetching metadata sources as they… (#174)

chore: fetch creator details before fetching metadata sources as they are helpful

Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>

---------

Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>
Co-authored-by: Muhammad Idil Haq Amir <idil.amir@gotocompany.com>
Co-authored-by: Muhammad Idil Haq Amir <idil.amir@tokopedia.com>
Co-authored-by: anjali9791 <anjalia271@gmail.com>
Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants