forked from raystack/guardian
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for expression in request body when fetching metada… #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fb0ccb
to
6a13658
Compare
6a13658
to
e1229da
Compare
…ta sources for appeal
e1229da
to
727b891
Compare
Gadigeppa-J
reviewed
Aug 13, 2024
Gadigeppa-J
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
harishkswami
pushed a commit
to harishkswami/guardian
that referenced
this pull request
Aug 23, 2024
goto#170) * feat: add support for expression in request body when fetching metadata sources for appeal * add a condition in http mock call --------- Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>
rahmatrhd
added a commit
that referenced
this pull request
Aug 27, 2024
* lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * lark support * fix: fix typo in mapstructure annotation * fix: map old notifier config to new multiple notifiers format * fix: fix slack client initialization with multiple workspaces * fix: fix lint errors * add json config for notifiers * add json config for notifiers * add json config for notifiers * add json config for notifiers * add json config for notifiers * add json config for notifiers * fix review commits * fix review commits * feat(email): handling email case sensitive (#165) * feat(email): handling email case sensitive * chore: handling list page * chore: handle case on filter --------- Co-authored-by: Muhammad Idil Haq Amir <idil.amir@tokopedia.com> * feat(gate): introduce gate provider (#164) * feat(gate): introduce gate provider * fix: send gate api key in query param * fix: handle non-success http codes * feat(notifier): expose variables in notifier criteria (#166) * feat: add support for google_oauth2 token. Related to issue: https://… (#169) * feat: add support for google_oauth2 token. Related to issue: #168 * add test cases * add test cases * add error formatting changes --------- Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com> * feat: add support for expression in request body when fetching metada… (#170) * feat: add support for expression in request body when fetching metadata sources for appeal * add a condition in http mock call --------- Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com> * ci: lock golangci-lint to v1.59 (#172) * ci: lock golangci-lint to v1.59 * ci: fix golangci-lint warnings * chore: fetch creator details before fetching metadata sources as they… (#174) chore: fetch creator details before fetching metadata sources as they are helpful Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com> --------- Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com> Co-authored-by: Muhammad Idil Haq Amir <idil.amir@gotocompany.com> Co-authored-by: Muhammad Idil Haq Amir <idil.amir@tokopedia.com> Co-authored-by: anjali9791 <anjalia271@gmail.com> Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ta sources for appeal