fix(provider-maxcompute): fixed and refactored maxcompute and oss client caching flow #203
Conversation
pkg/aliAuth/aliauth.go
Outdated
| "github.com/aliyun/aliyun-odps-go-sdk/odps/account" | ||
| ) | ||
|
|
||
| const assumeRoleDurationHours int64 = 1 |
There was a problem hiding this comment.
| const assumeRoleDurationHours int64 = 1 | |
| var assumeRoleDefaultDuration = time.Hour |
can we directly set the value into duration here?
pkg/aliAuth/aliauth.go
Outdated
|
|
||
| var durationSeconds = assumeRoleDurationHours * int64(time.Hour.Seconds()) | ||
|
|
||
| type AliAuthAccount struct { |
There was a problem hiding this comment.
let's make it internal
| type AliAuthAccount struct { | |
| type aliAuthAccount struct { |
pkg/aliAuth/aliauth.go
Outdated
| return nil, time.Time{}, fmt.Errorf("failed to assume role: %w", err) | ||
| } | ||
|
|
||
| expiryTimeStamp := time.Now().Add(time.Hour * time.Duration(assumeRoleDurationHours)) |
There was a problem hiding this comment.
can we check if token TTL is also present in from the assume role response, and use it for expiry instead of using default duration
There was a problem hiding this comment.
TTL is not present in the assume role response😕
pkg/aliAuth/aliauth.go
Outdated
There was a problem hiding this comment.
let's change this to pkg/aliauth/aliauth.go
| if odpsClient, ok := p.getCachedOdpsClient(ramRole, stsClientID, pc.URN); ok { | ||
| return odpsClient, nil | ||
| } | ||
| ramRole := p.getRamRole(creds, ramRoleFromAppeal) |
There was a problem hiding this comment.
i think let's rename ramRoleFromAppeal to overrideRamRole for easier understanding 😀
| } | ||
| delete(p.odpsClients, cachedClientKey) |
There was a problem hiding this comment.
let's do the mutex lock & unlock above and below this line only
| delete(p.odpsClients, cachedClientKey) | |
| p.mu.Lock() | |
| delete(p.odpsClients, cachedClientKey) | |
| p.mu.Unlock() |
There was a problem hiding this comment.
I think we should take the mutex lock at the time we're retreiving the value from map and release it once the delete operation is done. WDYT?
There was a problem hiding this comment.
reading the value doesn't need to lock the mutex but updating/deleting does
No description provided.