feat: allow appeal creation to continue on creator details fetch error #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_creator_details_failure
is a flag that lets the appeal creation to continue when the request to the identity provider (Policy.IAM) fails. If this is set to true and request to the identity provider fails (4xx or 5xx), the value ofcreator
field in the appeal will be nil. Note: any expression that tries to access$appeal.creator.*
is still evaluated as usual, it might need to have proper nil checking to avoid accessing nil value.closes #30
proton PR: goto/proton#21