Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow appeal creation to continue on creator details fetch error #33

Merged
merged 5 commits into from
May 22, 2023

Conversation

rahmatrhd
Copy link
Member

@rahmatrhd rahmatrhd commented May 15, 2023

  • allow_creator_details_failure is a flag that lets the appeal creation to continue when the request to the identity provider (Policy.IAM) fails. If this is set to true and request to the identity provider fails (4xx or 5xx), the value of creator field in the appeal will be nil. Note: any expression that tries to access $appeal.creator.* is still evaluated as usual, it might need to have proper nil checking to avoid accessing nil value.

closes #30

proton PR: goto/proton#21

@rahmatrhd rahmatrhd requested review from mabdh and bsushmith May 15, 2023 03:37
@coveralls
Copy link

coveralls commented May 15, 2023

Pull Request Test Coverage Report for Build 5030951402

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • 240 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.003%) to 75.933%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/appeal/service.go 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/appeal.go 5 95.45%
domain/policy.go 13 76.47%
core/appeal/service.go 110 81.59%
plugins/providers/metabase/client.go 112 68.5%
Totals Coverage Status
Change from base Build 4922259145: -0.003%
Covered Lines: 8118
Relevant Lines: 10691

💛 - Coveralls

domain/iam.go Outdated Show resolved Hide resolved
@rahmatrhd rahmatrhd requested review from bsushmith and mabdh May 16, 2023 04:33
@bsushmith bsushmith merged commit 6b9ff2a into main May 22, 2023
@bsushmith bsushmith deleted the non-blocking-creator-details-fetch branch May 22, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make appeal creator details fetch to external identity service non-blocking
4 participants