Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pagination support in ListUserApprovals api #6

Merged
merged 7 commits into from
Mar 17, 2023
Merged

feat: add pagination support in ListUserApprovals api #6

merged 7 commits into from
Mar 17, 2023

Conversation

bsushmith
Copy link
Collaborator

@bsushmith bsushmith commented Mar 16, 2023 •
edited
Loading

  • Add pagination support to ListUserApprovals & ListApprovals api in a backwards compatible way.

Proton PRs:

Closes #5

@coveralls
Copy link

coveralls commented Mar 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4445311660

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 75.138%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/approval_repository.go 4 6 66.67%
Totals Coverage Status
Change from base Build 4424514672: 0.005%
Covered Lines: 7906
Relevant Lines: 10522
💛 - Coveralls

@bsushmith bsushmith merged commit 31b0908 into main Mar 17, 2023
@bsushmith bsushmith deleted the 5-approvals-pagination branch March 17, 2023 07:49
lifosmin pushed a commit to lifosmin/guardian that referenced this pull request Aug 31, 2023
@bsushmith
feat(guardian): support pagination in ListApprovals (goto#6)
2462427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsav14nov utsav14nov utsav14nov approved these changes

@rahmatrhd rahmatrhd rahmatrhd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pagination in the approvals API
4 participants
@bsushmith @coveralls @rahmatrhd @utsav14nov