Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appeal): send appeal rejection notification for auto rejected steps #8

Merged
merged 2 commits into from
Mar 24, 2023
Merged

feat(appeal): send appeal rejection notification for auto rejected steps #8

merged 2 commits into from
Mar 24, 2023

Conversation

bsushmith
Copy link
Collaborator

  • send appeal rejection notification for auto rejected steps, which got auto-rejected at appeal creation time

Closes #7

@bsushmith
feat(appeal): send appeal rejection notification for auto rejected steps
99a0611 
- send appeal rejection notification for auto rejected steps, which got auto-rejected at appeal creation time
@coveralls
Copy link

coveralls commented Mar 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4466189287

  • 1 of 20 (5.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 75.002%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/appeal/service.go 1 20 5.0%
Totals Coverage Status
Change from base Build 4445330579: -0.1%
Covered Lines: 7906
Relevant Lines: 10541
💛 - Coveralls

@bsushmith
feat(appeal): send appeal rejection notification for auto rejected steps
8a7f77c 
- send appeal rejection notification for auto rejected steps, which got auto-rejected at appeal creation time
@bsushmith bsushmith marked this pull request as ready for review March 20, 2023 08:45
@bsushmith bsushmith requested a review from rahmatrhd March 24, 2023 05:47
@bsushmith bsushmith merged commit efc92d3 into main Mar 24, 2023
@bsushmith bsushmith deleted the 7-auto-rejection-notification branch March 24, 2023 06:06
lifosmin pushed a commit to lifosmin/guardian that referenced this pull request Aug 31, 2023
@anjali9791 @anjaliagg9791
feat(compass): support column level search. (goto#8)
b627c84 
- support column level search in Search API. Related to goto/compass#12
- add a new search parameter flags for extensibility

Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsav14nov utsav14nov utsav14nov approved these changes

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

send auto rejection notifications to user at appeal creation time
4 participants
@bsushmith @coveralls @rahmatrhd @utsav14nov