-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting max message size #54
Conversation
@a-marcellini you should be able to build from this branch and test the new setting. That would help me out a lot. I have to figure out why the Erlang 23 and 24 test suites won't complete. |
Thank's @lukebakken! We'll try and report you the outcome. |
@a-marcellini this pull request is complete. Please let me know the outcome of your test or if you have any issues. |
e0dbc22
to
b326c21
Compare
Fixes #47 Bump gen_smtp to 1.2.0 Add new `server_maxsize` setting, allowing users to override 10MiB limit Set maximum message size for EHLO as well, thanks @arjan Since we depend on the latest RabbitMQ source, we cannot test using Erlang 23 or 24 as only 25 is currently supported SIZE value must be a string Update versions in README
b326c21
to
9b6829a
Compare
@a-marcellini any update? |
Hi, I'managed to build and test your update, and I can say that it works like a charm! |
Thank you for testing @a-marcellini |
I've found a strange problem with the new release: if I use a client to send an email to rabbit directly it works.
The strange answer is:
Where 41943040 is the message size I put in rabbit.config while 10485760 is the default gen_smtp size, I suppose. |
@a-marcellini please open a new issue with those details: https://github.com/gotthardp/rabbitmq-email/issues |
Fixes #47
Bump gen_smtp to 1.2.0
cc @a-marcellini @mforde84