Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting max message size #54

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Allow setting max message size #54

merged 1 commit into from
Oct 19, 2022

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Oct 14, 2022

Fixes #47

Bump gen_smtp to 1.2.0

cc @a-marcellini @mforde84

@lukebakken
Copy link
Collaborator Author

@a-marcellini you should be able to build from this branch and test the new setting. That would help me out a lot. I have to figure out why the Erlang 23 and 24 test suites won't complete.

@a-marcellini
Copy link

Thank's @lukebakken! We'll try and report you the outcome.

@lukebakken lukebakken marked this pull request as ready for review October 17, 2022 18:00
@lukebakken
Copy link
Collaborator Author

@a-marcellini this pull request is complete. Please let me know the outcome of your test or if you have any issues.

Fixes #47

Bump gen_smtp to 1.2.0

Add new `server_maxsize` setting, allowing users to override 10MiB limit

Set maximum message size for EHLO as well, thanks @arjan

Since we depend on the latest RabbitMQ source, we cannot test using Erlang 23 or 24 as only 25 is currently supported

SIZE value must be a string

Update versions in README
@lukebakken
Copy link
Collaborator Author

@a-marcellini any update?

@a-marcellini
Copy link

a-marcellini commented Oct 19, 2022

@a-marcellini any update?

Hi, I'managed to build and test your update, and I can say that it works like a charm!
Great job!
The only problem we are experiencing is the multiarch build of the docker image. It thows a segmentation fault for arm arch., problably because of a bug of erlang, that, if we caught it right, they fixed a few days ago:
erlang/otp#6340

@lukebakken
Copy link
Collaborator Author

Thank you for testing @a-marcellini

@lukebakken lukebakken merged commit 33e08d8 into master Oct 19, 2022
@lukebakken lukebakken deleted the rabbitmq-email-47 branch October 19, 2022 12:21
@lukebakken
Copy link
Collaborator Author

@mforde84 @a-marcellini - https://github.com/gotthardp/rabbitmq-email/releases/tag/v1.1.0

@a-marcellini
Copy link

a-marcellini commented Oct 20, 2022

I've found a strange problem with the new release: if I use a client to send an email to rabbit directly it works.
However, if it is a mail server (postfix) that forward the same mail to rabbit, using it as a relay, it doesn't work.
Moreover:
If I use telnet:

telnet <rabbitserver> <mailport>

The strange answer is:

EHLO MyServer
250-mail.local
250-AUTH PLAIN LOGIN
250-SIZE 41943040
250-SIZE 10485760
250-8BITMIME
250-PIPELINING
250 SMTPUTF8

Where 41943040 is the message size I put in rabbit.config while 10485760 is the default gen_smtp size, I suppose.

@lukebakken
Copy link
Collaborator Author

@a-marcellini please open a new issue with those details:

https://github.com/gotthardp/rabbitmq-email/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with specifying settings for gen_
2 participants