Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not duplicate SIZE extension #56

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Do not duplicate SIZE extension #56

merged 1 commit into from
Oct 21, 2022

Conversation

lukebakken
Copy link
Collaborator

Fixes #55

@lukebakken lukebakken added this to the 1.1.1 milestone Oct 20, 2022
@lukebakken lukebakken self-assigned this Oct 20, 2022
@lukebakken
Copy link
Collaborator Author

@a-marcellini - please test this fix in your environment. Thanks a lot!

@a-marcellini
Copy link

The behaviour has definitely changed:

$ telnet localhost 2525
Trying ::1...
Connected to localhost.
Escape character is '^]'.
220 mail.local ESMTP rabbit_email_handler
EHLO COppa
250-mail.local
250-AUTH PLAIN LOGIN
250-SIZE 41943040
250-8BITMIME
250-PIPELINING
250 SMTPUTF8

And now postfix delivers the message and rabbit doesn't bounce it back.

Oct 20 15:00:41 mailserver postfix-in/qmgr[360]: D8CEE2A4061: from=<address1@mail.local>, size=13760367, nrcpt=1 (queue active)
...
Oct 20 15:00:41 mailserver postfix-in/smtp[490]: D8CEE2A4061: to=<address2@mail.local>, relay=rabbitmq[172.23.0.5]:2525, delay=4.9, delays=4.3/0.02/0.05/0.52, dsn=2.0.0, status=sent (250 015e8da796b65556d8831a0044a25f43)

So, it seems it's working!

@lukebakken
Copy link
Collaborator Author

@a-marcellini thank you for testing.

@lukebakken lukebakken merged commit 03a0d03 into master Oct 21, 2022
@lukebakken lukebakken deleted the rabbitmq-email-55 branch October 21, 2022 13:21
@lukebakken
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated size statement in EHLO
2 participants