feat(mongo): Update mongo driver to v3 #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ephemeral mongo won't work with the v3 driver and mongo2go fails. * Replaced with Testcontainers.MongoDb * Removed unused usings * Dropped netstandard 2.0 as mongo 3.0 removed target; it does support net472 but would require library to be built on windows agent * Update actions versions
|
Thanks! I will take a look. MongoJobWatcher observes the changeStream, when jobs are enqueued. It requires replica sets. Im guessing the test container is a single node. |
|
Hello, |
|
I merged it to master branch. I will release, when I got the last test running using testcontainers. Thanks!! |
|
Hi, |
|
Released v1.11.0 Thanks @ChrisMcKee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pass bar the MongoWatcherFacts; literally no idea what that's supposed to be testing.
Watching the mongo db the data written in the test is committed.
I'd say this is a breaking change as Mongo v3 drops support for netstandard2.0
They have kept net472 but that would probably require some fettling with the github actions. For now I've simply set the target for either