Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the use of /* istanbul ignore file */ #889

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrop
Copy link

@jrop jrop commented Jun 13, 2018

See #740 for more context. I had to look explicitly for this functionality before I found it documented in the issue tracker.

See gotwarlost#740 for more context.  I had to look explicitly for this functionality before I found it documented in the issue tracker.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.523% when pulling be962bc on jrop:patch-1 into bc84c31 on gotwarlost:master.

@lyahdav
Copy link

lyahdav commented Jun 29, 2018

Why is this not landed? I lost lots of time because I didn't realize /* istanbul ignore file */ existed.

EDIT: just realized this repo's readme has a Deprecation Notice 🙈

Copy link

@toggit toggit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look fine

@wtlin1228
Copy link

Please merge this PR 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants