Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password env var name #133

Closed
willbryant opened this issue Aug 17, 2022 · 1 comment · Fixed by #134
Closed

Password env var name #133

willbryant opened this issue Aug 17, 2022 · 1 comment · Fixed by #134
Labels
bug Something isn't working

Comments

@willbryant
Copy link
Contributor

Not clear what the env var should be called. Readme and first place in the code says MB_PASS:

ENV_VARS = [
    "DBT_DATABASE",
    "DBT_PATH",
    "DBT_MANIFEST_PATH",
    "MB_USER",
    "MB_PASS",

But the actual env var handling code says:

    "DBT_PATH",
    "DBT_MANIFEST_PATH",
    "MB_USER",
    "MB_PASS",

    @click.option(
        "--metabase_password",
        metavar="PASS",
        envvar="MB_PASSWORD",

Is the latter wrong?

@gouline gouline added the bug Something isn't working label Aug 17, 2022
@gouline
Copy link
Owner

gouline commented Aug 17, 2022

Not sure either one even works, they seem to exclude each other. It should be MB_PASSWORD if you feel like doing a quick PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants