Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema option case sensitivity #140

Closed
willbryant opened this issue Aug 23, 2022 · 1 comment · Fixed by #141
Closed

Schema option case sensitivity #140

willbryant opened this issue Aug 23, 2022 · 1 comment · Fixed by #141
Labels
bug Something isn't working

Comments

@willbryant
Copy link
Contributor

Docs say you can use:

    dbt_schema_excludes:
      - development
      - testing

And there's also support for a --dbt_schema_excludes command-line option.

However, you must actually upcase the schema name, unlike the example before, because the code that actually looks at this is:

if schema_excludes and node["schema"].upper() in schema_excludes:

I'm not really clear why the upper() is there. If it's just for the sake of normalising, then we also need to normalise the arguments?

@gouline gouline added the bug Something isn't working label Aug 23, 2022
@gouline
Copy link
Owner

gouline commented Aug 23, 2022

That's a bug. The point was to make them case insensitive, except it's forgetting to first make schema_excludes all the same case. The parameters includes and excludes are a good example, except they're inconsistent between manifest and folder parsers too. I'll look into making all three consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants