Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consistent model selection in parsing #141

Merged
merged 5 commits into from
Aug 28, 2022

Conversation

gouline
Copy link
Owner

@gouline gouline commented Aug 23, 2022

Resolves #140

@gouline
Copy link
Owner Author

gouline commented Aug 23, 2022

@willbryant See if this works for you before I merge and release

@willbryant
Copy link
Contributor

@gouline Nope it's actually doing completely NOOP runs on this branch. No further output after the "Session established successfully" banner.

Rolled back to 0.9.7 and it's working again, so don't think it's something wrong with my configuration.

@gouline
Copy link
Owner Author

gouline commented Aug 23, 2022

Drop any details of your configuration (e.g. which parser you use) that I would need to reproduce and I'll look into it when I have time.

@gouline
Copy link
Owner Author

gouline commented Aug 23, 2022

Actually @willbryant give it another go, I fixed a silly typo that may have been causing the noop 🤔

@willbryant
Copy link
Contributor

It's still skipping for me. -v shows:

DEBUG    Skipping DIM_CUSTOMERS in schema BI not in target schema PUBLIC                                                                                                                                                                                    dbt_manifest.py:65

Which is not what the previous version did. It starts working again if I add:

dbt_schema: bi

To my config. Whereas before, I just had:

  dbt_schema_excludes:
  - bi_dbt_ga4

IOW I think the behavior change is that now effectively only one schema at a time is supported?

@gouline
Copy link
Owner Author

gouline commented Aug 24, 2022

That makes sense, I was testing with the folder parser. Latest commit should fix the issue you raised.

@willbryant
Copy link
Contributor

Yup that's working - thanks.

@gouline gouline merged commit c64ec8a into master Aug 28, 2022
@gouline gouline deleted the fix/consistent-model-selection branch August 28, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema option case sensitivity
2 participants