-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum Python required version is not correct #52
Comments
Hmm, interesting! I think removing Also good idea on running the tests in GitHub Actions. Let's start with 3.6 for now and consider the version matrix as a future improvement. Let me know if you have any other questions to raise a PR for this. FYI @z3z1ma |
Thanks for pointing that out! Agreed. I like the Enum class actually. Its still nice and explicit and backwards compatible as fernandobrito pointed out. |
Hi!
The docs state that this amazing library "Requires Python 3.6 or above", and also
setup.py
states the same.However, some recently introduced changes (https://github.com/gouline/dbt-metabase/blob/master/dbtmetabase/models/metabase.py#L28) broke that. Using
typing.Literal
requires Python 3.8+. Running the library with Python 3.7 for example will raise:Alternatives on what to do:
Literal
type hint and instead use EnumOrthogonal to that, we could:
tox
I'm happy to contribute with a PR once the maintainer and contributors align on how to move forward 😄 .
The text was updated successfully, but these errors were encountered: