-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Python 3.6+ compatibility #55
Conversation
I need some help with this one. I can't build the project on Python 3.6. It seems the |
Another place where I need feedback: the package version during runtime magic that you use from https://pypi.org/project/setuptools-scm/#retrieving-package-version-at-runtime requires |
I converted this to draft for you, click "Ready for review" when it's no longer WIP. |
Also wrap the use of importlib
Also wrap the use of importlib
Thanks! Ready to be reviewed now.
But I'm more than open to suggestions on different approaches to solve those 3 issues. Also, is it fine if I "Squash and merge" once it's time to merge? The commit history in the branch is a bit messy 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of initial comments.
@z3z1ma should also review, since most of it is his code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks accounted for on the Enum update throughout the package. Great job & thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your efforts 🚀
Resolves #52
Literal
so the project runs on Python 3.6+