More column settings #145
Merged
More column settings #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why they have made a nested settings field in the column properties, but the behavior is that if we provide a settings entry, it will overwrite all the settings that appear in there in their responses (which are undocumented). So I've broken with the pattern a bit and am copying in the whole settings we were given, to avoid removing any other formatting changes made in the UI and make it easy to add more settings in the future.
|
Do they all have null defaults? Some Metabase API fields have non-null strings as defaults |
|
No, they don't. Have I done that wrong? I'm only setting them if they are explicitly set on the DBT side. |
|
Just checking, looks good |
gouline
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following properties: