Added support for aliased models and source blocks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added alias support in model parsing. Also added searching for "sources" yml blocks pushing table/column documentation to metabase (defining sources is recommended by dbt best practices and often done in tandem with creating staging models). Allows using "metabase.fk_ref" in sources or models .yml in order explicitly define a metabase relationship to a table which allows us to propagate the FK relationship properly to Metabase regardless of aliasing. metabase.fk_ref is looked for first in meta before falling back to default parser.
gouline
requested changes
May 10, 2021
There was a problem hiding this comment.
The code base is formatted with Black (https://github.com/psf/black), please format accordingly.
Replace print with log and ensure multiple sources in a single YML can be looped through- also formatted according to black
replace single quoting with double to conform to style guideline
useful when project structure is defined and ymls created but not yet populated
|
Changes requested are complete. I'll probably contribute more in the near future considering the successful adoption of dbt I worked with my company to achieve and our relatively high usage of metabase. |
gouline
reviewed
May 26, 2021
dbtmetabase/dbt.py
Outdated
| with open(path, "r") as stream: | ||
| schema = yaml.safe_load(stream) | ||
| if schema is None: | ||
| logging.warn(f"SKIPPING EMPTY/INVALID YML: {path}") |
There was a problem hiding this comment.
Please don't use all-caps in logs, it's inconsistent with other logs. Also no need for f-strings in logging statements, it takes arguments:
logging.warn("Skipping empty or invalid YAML: %s", path)
replaced last prints with info level logs and made invalid yml logger msg match rest
Re-added processing model logger info msg
updated log to match recommendation
|
@gouline Changes complete as recommended. 👍 |
gouline
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added alias support in model parsing. Also added searching for "sources" yml blocks pushing table/column documentation to metabase (defining sources is recommended by dbt best practices and often done in tandem with creating staging models). Allows using "metabase.fk_ref" in sources or models .yml in order explicitly define a metabase relationship to a table which allows us to propagate the FK relationship properly to Metabase regardless of aliasing. metabase.fk_ref is looked for first in meta before falling back to default parser.