Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle uppercase references from Metabase GUI derived queries #242

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Handle uppercase references from Metabase GUI derived queries #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98ca6d0
lowercase normal question exposures in from and join
alex-float-on Mar 13, 2024
2675334
handle edge case where source_table is None
alex-float-on Mar 14, 2024
3cc8985
change table name to uppercase in fixtures to verify changes
alex-float-on Mar 14, 2024
904bdf8
fix indentation
alex-float-on Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dbtmetabase/_exposures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,10 @@ def __extract_card_exposures(
elif query_source in ctx.table_names:
# Normal question
source_table = ctx.table_names.get(query_source)
_logger.info("Extracted model '%s' from card", source_table)
depends.add(source_table)
if source_table:
source_table = source_table.lower()
_logger.info("Extracted model '%s' from card", source_table)
depends.add(source_table)

# Find models exposed through joins
for join in query.get("query", {}).get("joins", []):
Expand All @@ -237,6 +239,7 @@ def __extract_card_exposures(
# Joined model parsed
joined_table = ctx.table_names.get(join_source)
if joined_table:
joined_table = joined_table.lower()
_logger.info("Extracted model '%s' from join", joined_table)
depends.add(joined_table)

Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/api/table.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"points_of_interest": null
},
"show_in_getting_started": false,
"name": "customers",
"name": "CUSTOMERS",
"caveats": null,
"updated_at": "2021-07-21T07:30:35.159586Z",
"entity_name": null,
Expand Down
Loading