Reduce query count #119
Merged
Reduce query count #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @raoulsullivan . I will take a look later today and merge. |
|
@raoulsullivan I merged your changes to master and noticed that the MySQL test fails. Do you have any thoughts? https://travis-ci.org/gouthambs/Flask-Blogging/jobs/427514097 |
|
Yeah, my thought is that I need to do a bit more work! The problem is almost certainly with the ordering of the results when joining the data together, which I remedied for my setup (postgres). Will spin up a mysql database now and update here. |
|
Addressed in #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was optimising site performance when I noticed that flask-blogging emits a lot of database queries, particularly on the index and sitemap views.
The following PR attempts to remedy that by joining the post, tag_posts, tag and user_posts table in both the get_posts and get_post_by_id methods. This results in moving the responsibility for joining posts to tags from the database to the Python.
The PR also changes from Flask-Cache to flask-caching to overcome this issue.
Enjoy!