This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Add govcms_security as a dependency in govcms_lagoon #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of our forklift process, we run this in order to ensure that certain required module are enabled: `drush pm-enable -y govcms_lagoon && drush pmu -y govcms_lagoon` ...which results in this: `The following module(s) will be enabled: govcms_lagoon, redis, fast404, lagoon_logs, environment_indicator` The govcms_security module should also be enabled as part of this process.
pandaskii
suggested changes
Mar 16, 2021
| @@ -8,3 +8,4 @@ dependencies[] = fast_404 | |||
| dependencies[] = clamav | |||
| dependencies[] = robotstxt | |||
| dependencies[] = lagoon_logs | |||
| dependencies[] = govcms_security | |||
There was a problem hiding this comment.
GovCMS D7 is using govcms_account_security, and GovCMS D8&9 is using govcms_security. So maybe we have to update the module name here. Otherwise, it is a good for security :)
There was a problem hiding this comment.
Perhaps GovCMS 7 needs a "stub" govcms_security module, which simply has govcms_account_security as a dependency? 🤷
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our forklift process, we run this in order to ensure that certain required module are enabled:
drush pm-enable -y govcms_lagoon && drush pmu -y govcms_lagoon...which results in this:
The following module(s) will be enabled: govcms_lagoon, redis, fast404, lagoon_logs, environment_indicatorThe govcms_security module should also be enabled as part of this process.