Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOVCMS-10212]: Add swarm to manage secrets for tokens. #388

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[GOVCMS-10212]: Add swarm to manage secrets for tokens. #388

merged 1 commit into from
Feb 29, 2024

Conversation

steveworley
Copy link
Contributor

Update pipeline.

@steveworley steveworley merged commit d61858e into 3.x-develop Feb 29, 2024
1 check failed
@steveworley steveworley deleted the feat/govcms-10212-github-token branch February 29, 2024 19:44
seanhamlin
seanhamlin reviewed Feb 29, 2024
View reviewed changes
README.md

Running `ahoy build` will build the containers. There are no file mounts from the host, but if you ssh into
one of the containers (eg `ahoy cli`) you will see the familiar /app/web, etc.

### Composer credentials

To avoid composer rate limiting you will need to providea personal access token that has read-only scope access to Github. Follow the [instructions from Github to create](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens) a personal access token.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/providea/provide a/

seanhamlin
seanhamlin reviewed Feb 29, 2024
View reviewed changes
.docker/Dockerfile.govcms

COPY --from=ghcr.io/salsadigitalauorg/shipshape:0.2.2 /usr/local/bin/shipshape /usr/local/bin/shipshape

ARG GOVCMS_PROJECT_VERSION
ARG COMPOSER_AUTH
ARG GITHUB_TOKEN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanhamlin seanhamlin seanhamlin left review comments

@yusufhm yusufhm yusufhm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveworley @yusufhm @seanhamlin