-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Stuck in a focus loop trying to focus outside day #1567
Labels
bug
Bug or Bug fixes
Comments
DanielJKelly
added a commit
to DanielJKelly/react-day-picker
that referenced
this issue
Oct 7, 2022
gpbl
added a commit
that referenced
this issue
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
This bug is related to focusing and outside days. It seems to occur in "range" mode when showing multiple months and the day that will be initially focused is part of the selected range and present on one calendar and also on the other calendar as an outside day. Both the "inside" day and the outside day have tabIndex="0" when inspected.
My initial thought is that outside days should not be considered focusable (or maybe at least have it be an option?), but perhaps I am missing a valid use case.
So perhaps this line should be checking for
!activeModifiers.outside
as well? I haven't tried it out myself though, so it's possible the issue is due to something else.To reproduce
Fork this CodeSandbox: https://codesandbox.io/s/react-day-picker-8-vl4ry with the code to reproduce the issue.
Steps
Expected behavior
I would expect that the focus should continue on to the next tabbable element and that the button shown below the DayPicker can be focused.
Screenshots
rdp-ex-bug.mov
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: