Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation allows to navigate before fromMonth #162

Closed
philippe-git opened this issue May 4, 2016 · 3 comments
Closed

Keyboard navigation allows to navigate before fromMonth #162

philippe-git opened this issue May 4, 2016 · 3 comments

Comments

@philippe-git
Copy link

It doesn't feel critical at all, but I wanted to bring it up nonetheless 😄

Steps to reproduce:

  1. Open a day picker with restricted months, e.g. http://www.gpbl.org/react-day-picker/examples/#restricted
  2. Select one of the allowed days
  3. Using the left arrow key, keep navigating to previous days: you'll be able to navigate to days before fromMonth

Screencast: http://cl.ly/1E3n441u462h

Note: this issue doesn't exist when navigating through months, rather than days, using the keyboard (i.e. when pressing left arrow while focus is on a month label rather than a day box)

@gpbl gpbl added the bug label May 4, 2016
@gpbl
Copy link
Owner

gpbl commented May 4, 2016

Woah true! Thanks for the precise report. Fix coming soon!

@gpbl
Copy link
Owner

gpbl commented May 15, 2016

This has been fixed in the next major version, I guess after #132. Version 2 doesn't have such big breaking changes, so I'd suggest to upgrade to it once it is released :)

@gpbl gpbl closed this as completed May 15, 2016
@philippe-git
Copy link
Author

Awesome, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants