Keyboard nav and aria improvements #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @limscoder thanks so much for this PR! Really appreciated. I'm on vacation now, I can give a look to it in the next days. 🌴 |
|
Any progress on reviewing this? Can I answer any questions? |
| @@ -429,10 +468,17 @@ export default class DayPicker extends Component { | |||
| tabIndex = this.props.tabIndex; | |||
| } | |||
| } | |||
|
|
|||
| const ariaLabel = this.props.localeUtils.formatDate ? | |||
| this.props.localeUtils.formatDate(day) : day.toDateString(); | |||
There was a problem hiding this comment.
The formatDate here is a new function to add to the LocaleUtils right? I can take care of this (need to update docs, tests, etc. 😄)
We should add the locale props as second argument to the function, so implementers can use their own localization utils.
There was a problem hiding this comment.
yep, new function.
|
Thanks again @limscoder, those are great additions. They are going in the next major release, I'm working on it this week. |
|
thx |
gpbl
added a commit
that referenced
this pull request
Apr 8, 2016
This is required to add the aria-label attribute. See #132 for more details.
This was referenced May 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
keyboard nav:
aria:
Any background context you want to provide?
There are 5 commits. Started with some refactoring to simplify DayPicker, then added keyboard nav features and aria labels to date cells, so that it works better with screen readers.
Where should the reviewer start?
Look at each commit independently.
How should this be manually tested?
Test keyboard nav in example app.
Test with screen reader in example app (cmd-f5 to enable voiceover in OSX).