Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default styles overwrite button styles used in the footer #2377

Closed
hsnaydd opened this issue Aug 16, 2024 · 1 comment · Fixed by #2383
Closed

Default styles overwrite button styles used in the footer #2377

hsnaydd opened this issue Aug 16, 2024 · 1 comment · Fixed by #2383

Comments

@hsnaydd
Copy link
Contributor

hsnaydd commented Aug 16, 2024

The reset styles should only affect calendar buttons.

import Button from "../components/Button"
import { DayPicker } from "react-day-picker";

export function Start() {
  return (
    <DayPicker
      footer={
        <Button>...</Button> // <= `.rdp-root button` overwrites this Button's style
      }
     />
  );
}
@gpbl
Copy link
Owner

gpbl commented Aug 16, 2024

You are right @hsnaydd. I think we should use a .rdp-button class name instead. Thanks for the report!

hsnaydd added a commit to hsnaydd/react-day-picker that referenced this issue Aug 19, 2024
hsnaydd added a commit to hsnaydd/react-day-picker that referenced this issue Aug 19, 2024
hsnaydd added a commit to hsnaydd/react-day-picker that referenced this issue Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants