Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DayPicker-Weekdays should have a table-row as child #82

Closed
gpbl opened this issue Nov 11, 2015 · 1 comment
Closed

DayPicker-Weekdays should have a table-row as child #82

gpbl opened this issue Nov 11, 2015 · 1 comment

Comments

@gpbl
Copy link
Owner

gpbl commented Nov 11, 2015

As pointed out by @nkbt, this commit broke some styles, so the proposed solution by @jkillian is to remove display: table-row in the CSS.

However it is preferred to have a table-row inside DayPicker-Weekdays, which is a table-header-group.

So we should revert that commit and restore the surrounding div. This div was however missing a className, thus the confusion that lead to this problem: I'd assign to this element the DayPicker-Weekdays-row class.
@gpbl gpbl added the bug label Nov 11, 2015
gpbl referenced this issue Nov 11, 2015
@gpbl
Do not render a <div> surrounding Weekday
0164a38
@gpbl gpbl mentioned this issue Nov 11, 2015
Closed
@gpbl gpbl mentioned this issue Nov 11, 2015
Merged
@gpbl gpbl closed this as completed in e98a922 Nov 11, 2015
gpbl added a commit that referenced this issue Nov 11, 2015
@gpbl
Merge pull request #83 from gpbl/fix-row
3928b85 
Restore the row for the weekdays header (fix #82)
@nkbt
Copy link

nkbt commented Nov 11, 2015

Oh, so I actually ran into bug. Thanks for the prompt fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpbl @nkbt