Added caption layout for both dropdowns and buttons #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanockert
force-pushed
the
add-caption-both
branch
from
651bcb9
to
bd6a91f
Compare
gpbl
reviewed
Feb 4, 2023
- Added `captionLayout="dropdown-buttons"` to show both month/year dropdowns and prev/next month buttons - Added test files - Related feature request: https://github.com/gpbl/react-day-picker/issues/1663
seanockert
force-pushed
the
add-caption-both
branch
from
bd6a91f
to
8755ae1
Compare
gpbl
approved these changes
Feb 12, 2023
|
Thank you guys for adding this feature! We are very interested to start using it, do you know when you plan on publishing the next version on npm @gpbl ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
captionLayoutoption currently accepts EITHER month/year dropdowns OR prev/next month navigation buttons, but not both. We need both navigation controls for our app.This option was available in v7 but not in v8
Other users would also like to have this option: https://github.com/gpbl/react-day-picker/issues/1663
Analysis
The simplest way is to add a new option for
captionLayout.I considered passing an array eg.
captionLayout={['dropdowns', 'buttons']}but this would be a breaking change and add complexity. I kept it as a string and addedbothoption.Solution
captionLayout="both"to show both month/year dropdowns and prev/next month buttonsCaptionNavigation.tsx. I can rewrite this component if you preferreact-day-picker-both-captions-interaction.mov