-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure weekday labels respect the locale’s firstDayOfWeek
#220
Conversation
Thanks! Is it possible for you to add a test to reproduce this? I believe it is a fix for #207 – I need to investigate this bug better, but it looks it is a potentially breaking change. |
@gpbl Yep, will add a test when I get a chance! I don't think it should be a breaking change though, since it's just passing through some additional data. |
Thanks @makenosound for your help! |
Published as v3 👍 |
No worries, @gpbl. Thanks for the great little lib. |
I noticed today that the
firstDayOfWeek
locale setting isn’t respected by the weekday headings.This change passes through that prop to the
<Weekdays>
component and then appropriately normalises it to a0-6
integer using the modulo operator so that they do match up to the dates below.