Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure weekday labels respect the locale’s firstDayOfWeek #220

Merged
merged 4 commits into from
Oct 11, 2016

Conversation

makenosound
Copy link
Contributor

I noticed today that the firstDayOfWeek locale setting isn’t respected by the weekday headings.

This change passes through that prop to the <Weekdays> component and then appropriately normalises it to a 0-6 integer using the modulo operator so that they do match up to the dates below.

makenosound added a commit to team-formalist/formalist-standard-react that referenced this pull request Oct 10, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 99.74% when pulling 45c6611 on makenosound:fix-weekday-labels into 2e44ec7 on gpbl:master.

@gpbl
Copy link
Owner

gpbl commented Oct 10, 2016

Thanks! Is it possible for you to add a test to reproduce this? I believe it is a fix for #207 – I need to investigate this bug better, but it looks it is a potentially breaking change.

@makenosound
Copy link
Contributor Author

@gpbl Yep, will add a test when I get a chance!

I don't think it should be a breaking change though, since it's just passing through some additional data.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 99.74% when pulling 20e2117 on makenosound:fix-weekday-labels into 2e44ec7 on gpbl:master.

@makenosound
Copy link
Contributor Author

@gpbl I’ve added a test for that now, and yep, it should fix up #207.

@gpbl
Copy link
Owner

gpbl commented Oct 11, 2016

Thanks @makenosound for your help!

@gpbl gpbl merged commit b965b7e into gpbl:master Oct 11, 2016
gpbl added a commit that referenced this pull request Oct 11, 2016
gpbl added a commit that referenced this pull request Oct 11, 2016
@gpbl
Copy link
Owner

gpbl commented Oct 11, 2016

Published as v3 👍

@makenosound
Copy link
Contributor Author

No worries, @gpbl. Thanks for the great little lib.

@gpbl gpbl mentioned this pull request Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants