Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate output HTML #2475

Merged
merged 7 commits into from
Sep 19, 2024
Merged

feat: validate output HTML #2475

merged 7 commits into from
Sep 19, 2024

Conversation

gpbl
Copy link
Owner

@gpbl gpbl commented Sep 19, 2024 •
edited
Loading

  • add tests to validate HTML
  • add missing type="button" to Day buttons
  • add scope="col" to weekdays headers
  • add scope="row" to week numbers cells
  • removed unnecessary role attributes.
    • note: jest tests must be updated using cell instead gridcell role

@gpbl gpbl changed the title fix: remove unnecessary role attributes feat: validate output HTML Sep 19, 2024
@gpbl gpbl merged commit ea56b3f into main Sep 19, 2024
10 checks passed
@gpbl gpbl deleted the gpbl/validate-html branch September 19, 2024 23:54
This was linked to issues Sep 19, 2024
Add missing type to Button elements #2468
Closed
Add missing scope to th elements #2469
Closed
@lucentlabz lucentlabz mentioned this pull request Nov 5, 2024
Open
@gpbl gpbl mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing scope to th elements Add missing type to Button elements
1 participant
@gpbl