fix: setting defaultMonth the next year when using the dropdown mode does not render the calendar #2783
+95
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2776
Description
The issue happens because the valid months of the calendar are calculated internally in the
useCalendarhook when thelayoutof the day picker is adropdowntype, but other inner logic parts of the day picker use thestartMonthandendMonthprops as the calendar limits, which in this use case isundefined.Changes
This PR unifies the source of truth for the start and end months of the day picker, using the
navStartandnavEndreturned by thegetNavMonthsin theuseCalendarhook as the source of truth.This also means that from now on, we should NOT use the
startMonthandendMonthprops directly, and instead use thenavStartandnavEndvalues.