Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add componentWillReceiveProps #364

Closed
wants to merge 1 commit into from
Closed

Conversation

youreme
Copy link

@youreme youreme commented May 25, 2017

Hi,

When DayPickerInput gets nextProps, it doesn't change its states.
How about adding componentWillReceiveProps lifecycles?

After it mounted,
if it doesn't trigger any change events, the value state is different from value property.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.817% when pulling 9d1d043 on youreme:develop into 099057d on gpbl:master.

@gpbl
Copy link
Owner

gpbl commented May 25, 2017

Thanks! I need to add a test before merging this :)

@gpbl
Copy link
Owner

gpbl commented May 25, 2017

Superseded by #365

@gpbl gpbl closed this May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants